23971 Proposed API and schema changes #25013
Draft
+107
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
jacobshandling
commented
Dec 26, 2024
jacobshandling
changed the title
lucasmrod
previously approved these changes
Dec 26, 2024
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
iansltx
reviewed
Dec 28, 2024
lucasmrod
previously approved these changes
Dec 30, 2024
jacobshandling
force-pushed
the
23971-api-changes
branch
from
3c1a8ad to
ff956d3
Compare
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
|
Hey @rachaelshaw, hope you had a nice vacation. Assigning you this ticket, how do these specs look from product POV? |
rachaelshaw
requested changes
Jan 6, 2025
jacobshandling
had a problem deploying
to
Docker Hub
GitHub Actions
Error
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
|
@rachaelshaw @lucasmrod @sgress454 added our decisions to this issue description, thanks for your insights! |
jacobshandling
force-pushed
the
23971-api-changes
branch
from
18c4e78 to
2615745
Compare
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
lucasmrod
previously approved these changes
Jan 8, 2025
added 6 commits
January 9, 2025 13:50
jacobshandling
force-pushed
the
23971-api-changes
branch
from
2615745 to
a1a3d1e
Compare
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #25034
API changes:
this PR diff ("available_teams" change is adding missing documentation for current API behavior)
schema changes:
userstable,settings, typejson. Defaults to{}. New setting,hidden_host_columns, added or updated on first relevant API call per user.semantics
"hidden_host_columns"field means "not yet set, use defaults":{"settings":{"hidden_host_columns": null}}"hidden_host_columns"field means "no columns hidden, show all columns in the UI":{"settings":{"hidden_host_columns": []}}Updates 1/7/25 per discussion with @rachaelshaw @lucasmrod @sgress454:
include_ui_settings=trueincluded withGETs to/meor/users/:idwill trigger considering the API call to be a contributor API call, giving more flexibility for future changes. Note that this is the first time we have one endpoint that can be conditionally considered a contributor endpoint depending on how it is called.